Fix SAML2 endpoints registration when base_url includes a path#483
Fix SAML2 endpoints registration when base_url includes a path#483guillomovitch wants to merge 2 commits intoIdentityPython:masterfrom
Conversation
|
Note there is a related PR #451 , which tries to take care of all backend and frontend modules. I'd be happy if you could point out, if there are any key differences. |
1cbaf03 to
ee5c0a9
Compare
|
Thanks for the remark, I didn't noticed this PR. It seems we have now three different issues (#148, #179, #404), and two different PR (#451, #483) about the same problem :) Regarding your own PR, it seems far more complete than mine, which was a quick'n'dirty fix for my own use case. I lack knowledge of SATOSA internals, but if I understand correctly, you modified routing to fix the issue. This strategies let persists inconsistencies between modules configurations, some using absolute URLs (SAML backend and frontends), ie: I'd personally prefer to enforce the same overall convention for configuration files. And I also feel easier to deduce absolute URLs by appending a relative one to base URL, when needed, than to try to deduce relative URLs from absolute ones, using complex parsing. BTW, your PR doesn't cover the SAML2 backend, which has to be fixed as well, at least for the reload-metada endpoint, and probably for others too. |
declare only relative URLs in configuration, so as to fix registration when base URL contains a path (issue IdentityPython#179), and expose those endpoints to outer world by appending base URL when needed. This is much simpler than parsing absolute URLs, and more consistent with OIDC frontends behaviour.
Rather have a working metadata exposure endpoint registration, whatever base url is, than try to deduce it from entityID.
ee5c0a9 to
404fed0
Compare
This PR fixes issue #179.
I didn't fix metadata endpoint registration, tough.